starknet_committer_and_os_cli: build storage tries concurrently based on py config#12444
Open
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/always-cache-on-writefrom
Open
Conversation
This was referenced Feb 10, 2026
|
This change is |
Contributor
Author
Contributor
Author
nimrod-starkware
left a comment
nimrod-starkware
left a comment
There was a problem hiding this comment.
py side:
https://reviewable.io/reviews/starkware-industries/starkware/40161
@nimrod-starkware made 1 comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @nimrod-starkware).
nimrod-starkware
force-pushed
the
nimrod/parallel-reads/always-cache-on-write
branch
from
b8c6929 to
f60e9a7
Compare
nimrod-starkware
force-pushed
the
nimrod/parallel-reads/py-config
branch
from
b4f2ba1 to
a687f27
Compare
nimrod-starkware
force-pushed
the
nimrod/parallel-reads/always-cache-on-write
branch
from
f60e9a7 to
a861514
Compare
nimrod-starkware
force-pushed
the
nimrod/parallel-reads/py-config
branch
from
a687f27 to
2f403ef
Compare
nimrod-starkware
force-pushed
the
nimrod/parallel-reads/always-cache-on-write
branch
from
a861514 to
ac85e19
Compare
nimrod-starkware
force-pushed
the
nimrod/parallel-reads/py-config
branch
from
2f403ef to
a91dd91
Compare
nimrod-starkware
force-pushed
the
nimrod/parallel-reads/always-cache-on-write
branch
from
ac85e19 to
fc5aed1
Compare
nimrod-starkware
force-pushed
the
nimrod/parallel-reads/py-config
branch
from
a91dd91 to
642ea0b
Compare
nimrod-starkware
force-pushed
the
nimrod/parallel-reads/always-cache-on-write
branch
from
fc5aed1 to
78aa147
Compare
nimrod-starkware
force-pushed
the
nimrod/parallel-reads/py-config
branch
from
642ea0b to
4e65158
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Small config plumbing change with test coverage; main risk is input compatibility (older JSON missing the new required field) and altered runtime concurrency behavior when enabled.
Overview
The CLI raw input schema now includes
config.build_storage_tries_concurrently, andparse_inputpasses this value intoReaderConfig::new(removing the previous hardcodedfalse).Tests are updated to include the new config field in the serialized input fixtures and to assert the expected
ReaderConfigvalues.Written by Cursor Bugbot for commit 4e65158. This will update automatically on new commits. Configure here.